Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live demo link #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Live demo link #115

wants to merge 2 commits into from

Conversation

Roy-Orbison
Copy link

No description provided.

@Roy-Orbison Roy-Orbison mentioned this pull request May 31, 2018
@neocotic
Copy link
Owner

Looks like I need to update the build. I'll probably shrink-wrap the package to avoid this breaking again. I'll try to find time to fix this soon.

As for your change, this is a tricky one as you may not be viewing the master branch. I'm thinking about just duplicating the link to the hosted demo somewhere else in the demo. I'm planning on consolidating the repos back into a managed monorepo to make it easier to contribute and for me to maintain, as I have less time to do so these days. This process will involve some rework for the docs as I'm hoping to make it even clearer to setup and use in any way possible.

@Roy-Orbison
Copy link
Author

Well the current demo link doesn't change with the checked out branch, either. I don't see it as any worse.

@neocotic
Copy link
Owner

Sorry, I might not have explained my point. My intention for the demo.html reference where this PR inserts a link was more to inform contributors on how to test changes in their local working copy so I'm reluctant to confuse this purpose by linking it to a master remote reference.

I hope this makes more sense.

@Roy-Orbison
Copy link
Author

Ah, got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants