Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to current geotools (22.1) #363

Closed

Conversation

stevenleadbeater
Copy link

All tests are passing and I have loaded the jars from the zip file to a geoserver war for current geoserver and added a neo4j data source without errors being thrown

@mprins
Copy link

mprins commented Dec 27, 2019

👍

you might want to change "oraclejdk8" in

spatial/.travis.yml

Lines 2 to 4 in df8d737

jdk:
- oraclejdk8

to "openjdk8" as Oracle is no longer available in the default/current build images due to EOL / Paid maintainance

@stevenleadbeater
Copy link
Author

openjdk8

done

@stevenleadbeater
Copy link
Author

I've had to fix some further issues on this, it appears as though GeoServer now loads the database location in as a URI which was confusing the location of the database on disk. This is now resolved and I have loaded up layers from the TestDynamicLayers class in GeoServer and successfully previewed them as OSM

@stevenleadbeater
Copy link
Author

stevenleadbeater commented Jan 2, 2020

fixes #275 and #360

@stevenleadbeater stevenleadbeater mentioned this pull request Jan 2, 2020
@craigtaverner
Copy link
Contributor

Hi Steven. Thanks for this great contribution. I'd love to review and merge it, but we need to handle a tiny bit of paperwork first. Have you signed the CLA agreement described at https://neo4j.com/developer/cla/. It is a simple IP sharing agreement that we require to accept contributions. Normally it simply involves sending an email, so read the above link and send the email. Then I can look at merging this PR.

@stevenleadbeater
Copy link
Author

Thanks @craigtaverner , I've sent the email

@craigtaverner
Copy link
Contributor

Hi @stevenleadbeater, I've not seen the email yet. Can you verify that you sent it to the right address?

@stevenleadbeater
Copy link
Author

I sent it to cla@neotechnology.com, is that not right? @craigtaverner

@craigtaverner
Copy link
Contributor

That should have worked, and I see emails to that address working as recently as last week. Can you perhaps retry to cla@neo4j.com instead? That is the current official address.

@stevenleadbeater
Copy link
Author

Thanks @craigtaverner I've sent that through

@craigtaverner
Copy link
Contributor

This is strange. I've received cla emails as recently as an hour ago, but nothing from you. I'll check with others at this end to see what is happening. In the meantime, can you join neo4j-users.slack.com so we can DM and discuss how to resolve this. I think github issue comments are not the right forum for that.

@Andy2003
Copy link
Collaborator

We are already on geotools 30.2 see also: #399

@Andy2003 Andy2003 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants