Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #346

Closed
wants to merge 4 commits into from
Closed

Readme update #346

wants to merge 4 commits into from

Conversation

devbaraus
Copy link

Just a simple update on the readme.
It took me a while to get started even with the old example, the result I expected (the one in the image) wasn't the same I had.
Also, I added some more configuration like the visConfig so other people just from the read know they can change more stuff in the visualization.

Copy link
Collaborator

@thebestnom thebestnom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good changes, thanks!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -176,9 +186,15 @@ And define our draw() function:
relationships: {
INTERACTS: {
value: "weight"
[NeoVis.NEOVIS_ADVANCED_CONFIG]: {
function: {
title: (relationship) => relationship.properties.weight,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here you are using title wrong 😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would it be?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the title function in nodes 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#346 (comment)
I already commented here, my bad for not commenting on both lines 😅

@devbaraus devbaraus closed this by deleting the head repository Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants