-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modified the projects and zones function #2083
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: swastik959 <Sswastik959@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the required GCP libraries to pyproject.toml
first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @swastik959 for the contribution! We really appreciate it. This is definitely a good start, as @fangchenli mentioned, we will need to add the required google python library as a dependency in the pyproject.toml
.
@iameskild I wanted to ask should I modify the check credential method to point to credential json file for explicit parameter input |
@swastik959 that's a good question. I think we can start by supporting OAuth2 authentication for service accounts, this might be helpful: https://googleapis.github.io/google-api-python-client/docs/oauth.html#credentials |
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@iameskild hi I have made few commits can you please review them . also can you please tell me how can I test them locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @swastik959! I will have a closer look later today but in the meantime, do you mind making sure the tests/CI are passing?
fixes #2019
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Any other comments?