Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified the projects and zones function #2083

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

swastik959
Copy link

fixes #2019

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@fangchenli fangchenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the required GCP libraries to pyproject.toml first.

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @swastik959 for the contribution! We really appreciate it. This is definitely a good start, as @fangchenli mentioned, we will need to add the required google python library as a dependency in the pyproject.toml.

@swastik959
Copy link
Author

@iameskild I wanted to ask should I modify the check credential method to point to credential json file for explicit parameter input

@iameskild
Copy link
Member

@swastik959 that's a good question. I think we can start by supporting OAuth2 authentication for service accounts, this might be helpful: https://googleapis.github.io/google-api-python-client/docs/oauth.html#credentials

swastik959 and others added 2 commits November 3, 2023 11:43
Signed-off-by: swastik959 <Sswastik959@gmail.com>
@swastik959
Copy link
Author

@iameskild hi I have made few commits can you please review them . also can you please tell me how can I test them locally

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @swastik959! I will have a closer look later today but in the meantime, do you mind making sure the tests/CI are passing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Changes requested 🧱
Development

Successfully merging this pull request may close these issues.

Use Google python SDK instead of gcloud subprocess
3 participants