Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: fix typing error in hookspecs, refactor NebariStage #1974

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from
Open

TYP: fix typing error in hookspecs, refactor NebariStage #1974

wants to merge 31 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 3, 2023 •
edited

Reference Issues or PRs

xref #1800 ##1894

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

fangchenli
fangchenli commented Sep 4, 2023
View reviewed changes
src/nebari/hookspecs.py Outdated Show resolved Hide resolved
@fangchenli fangchenli marked this pull request as ready for review September 4, 2023 17:43
@iameskild iameskild added type: maintenance 🛠 Day-to-day maintenance tasks type:extension Nebari Extension labels Sep 4, 2023
iameskild
iameskild suggested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli! I left a few comments that I think we should discuss a bit further.

src/nebari/hookspecs.py Outdated Show resolved Hide resolved
src/nebari/hookspecs.py Show resolved Hide resolved
@iameskild iameskild mentioned this pull request Sep 4, 2023
Merged
10 tasks
fangchenli and others added 17 commits September 4, 2023 20:54
@fangchenli
Merge remote-tracking branch 'upstream/develop' into typing-hookspecs
0e07f3c
@fangchenli
Merge remote-tracking branch 'origin/typing-hookspecs' into typing-ho…
f762e2b 
…okspecs
@fangchenli
refactor
4b1d035
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
ab840a3
@fangchenli
Merge branch 'develop' into typing-hookspecs
06288d6
@fangchenli
Merge branch 'develop' into typing-hookspecs
5f283fa
@fangchenli
raise error instead of exit
838262b
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
a08f1fc
@fangchenli
fix msg
c0d32fa
@fangchenli
Merge remote-tracking branch 'origin/typing-hookspecs' into typing-ho…
aae1261 
…okspecs
@fangchenli
fix msg
6413ca6
@fangchenli
Merge remote-tracking branch 'upstream/develop' into typing-hookspecs
9974e2a
@fangchenli
fix render return type
3ac85dc
@fangchenli
fix destroy method signature mismatch
5869538
@pre-commit-ci
[pre-commit.ci] Apply automatic pre-commit fixes
5a281dd
@fangchenli
fix import in bootstrap stage
6efaa67
@fangchenli
revert change
bb643f4
@iameskild iameskild added this to the The Release After Next milestone Oct 18, 2023
@iameskild
Copy link
Member

@costrouc could you have a look at this PR?

@pavithraes pavithraes removed this from the The Release After Next milestone Dec 19, 2023
@dcmcand
Copy link
Contributor

dcmcand commented Mar 18, 2024

@viniciusdc will check

@viniciusdc
Copy link
Contributor

This has some big refactorings in the Nebari Stage which needs to be retested now that we changed a bit the behavior for the default schema dumps -- I will follow up on this, next week

@viniciusdc viniciusdc added the needs: follow-up 📫 Someone needs to get back to this issue or PR label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iameskild iameskild Awaiting requested review from iameskild

@costrouc costrouc Awaiting requested review from costrouc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs: follow-up 📫 Someone needs to get back to this issue or PR type:extension Nebari Extension type: maintenance 🛠 Day-to-day maintenance tasks
Projects
🪴 Nebari Project Management
Status: Changes requested 🧱
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fangchenli @iameskild @dcmcand @viniciusdc @pavithraes