Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Google python SDK instead of gcloud subprocess #2019

Open
iameskild opened this issue Sep 19, 2023 · 1 comment · May be fixed by #2083
Open

Use Google python SDK instead of gcloud subprocess #2019

iameskild opened this issue Sep 19, 2023 · 1 comment · May be fixed by #2083
Labels
area: user experience 👩🏻‍💻 good first issue Good for newcomers provider: GCP type: maintenance 🛠 Day-to-day maintenance tasks

Comments

@iameskild
Copy link
Member

To interact with the Google cloud API, we are calling gcloud via subprocess in the google_cloud provider module. This requires the user have gcloud installed and configured on their machine. Given that all of the calls we are making can be made using the python SDK, I think this should be the preferred method of interacting with the Google Cloud API.
@iameskild iameskild added the good first issue Good for newcomers label Oct 9, 2023
@pavithraes pavithraes added the type: maintenance 🛠 Day-to-day maintenance tasks label Oct 9, 2023
@swastik959 swastik959 linked a pull request Oct 22, 2023 that will close this issue
Open
10 tasks
@swastik959
Copy link

@iameskild hi i have made a pr wanted to know if this is what you want so I can proceed further also I wanted to ask show I modify the check credential method to point to credential json file for explicit parameter input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: user experience 👩🏻‍💻 good first issue Good for newcomers provider: GCP type: maintenance 🛠 Day-to-day maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modified the projects and zones function swastik959/nebari
3 participants
@pavithraes @iameskild @swastik959