Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conda-store artifact/storage endpoints #159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix conda-store artifact/storage endpoints #159

wants to merge 2 commits into from

Conversation

viniciusdc
Copy link
Collaborator

@viniciusdc viniciusdc commented Apr 9, 2024 •
edited

Reference Issues or PRs

#158

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

viniciusdc
viniciusdc commented Apr 9, 2024
View reviewed changes
roles/traefik/templates/traefik_dynamic.yaml
@@ -87,7 +87,7 @@ http:
service: "dummy"

minio:
rule: "Host(`{{ traefik_domain | default(hostvars[groups['hpc_master'][0]].ansible_ssh_host) }}`) && PathPrefix(`/minio`)"
rule: "Host(`{{ traefik_domain | default(hostvars[groups['hpc_master'][0]].ansible_ssh_host) }}`)"
Copy link
Collaborator Author

@viniciusdc viniciusdc Apr 9, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the old /minio path would require some changes on how conda-store prepares the URLs internaly which would not be feasible at the moment

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like to be part of the S3 compatibility scheme, though couldn't find a ref. link besides this minio/minio-py#1140 (comment) comment.

@viniciusdc viniciusdc requested a review from aktech April 9, 2024 20:19
aktech
aktech reviewed Apr 10, 2024
View reviewed changes
roles/traefik/defaults/main.yml
@@ -34,4 +34,4 @@ conda_store_port: "5000"

# role: minio
minio_internal_port: "9001"
minio_external_port: "9000"
minio_external_port: "9080"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still pointing to 9080? It would not work out of the box with App proxy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viniciusdc @aktech