Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docs to reflect the ability to scale to zero in AWS #456

Merged
merged 1 commit into from May 14, 2024

Conversation

jscearce3
Copy link

@jscearce3 jscearce3 commented May 13, 2024

Reference Issues or PRs

Addresses issue #410.
Adjusts language to reflect the ability to scale to zero with the AWS provider.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • [x ] Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • [x ] The content is written with plain language (where relevant).
  • [x ] If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • [ x] All links describe where they link to (for example, check the Nebari website).
  • [ x] This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link

netlify bot commented May 13, 2024

Deploy Preview for nebari-docs ready!

Name Link
🔨 Latest commit 9e31d75
🔍 Latest deploy log https://app.netlify.com/sites/nebari-docs/deploys/664227b84e4b7d000859849a
😎 Deploy Preview https://deploy-preview-456--nebari-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kcpevey kcpevey requested a review from viniciusdc May 14, 2024 13:52
Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viniciusdc viniciusdc merged commit 705b7fd into nebari-dev:main May 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

None yet

2 participants