Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement column resizing #22

Merged
merged 5 commits into from
May 14, 2024
Merged

Implement column resizing #22

merged 5 commits into from
May 14, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 13, 2024

Closes #19

resizing

Tested on:

  • Chrome
  • Firefox
  • Webkit

Copy link
Contributor

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-new-launcher/resize-columns

@krassowski
Copy link
Member Author

bot please update snapshots

@krassowski krassowski closed this May 13, 2024
@krassowski krassowski reopened this May 13, 2024
unprefixed user-select in TP version)
@krassowski
Copy link
Member Author

On Webkit (Safari) there is some odd double ellipsis on kernel name:

image

also the heading label is not bold, and the star is off center (for which I opened #24).

@krassowski
Copy link
Member Author

krassowski commented May 13, 2024

I can even make it show three copies:

image

It looks like a bug in the webkit rendering pipeline when using position relative with top. I see a number of bugs in WebKit about ellipsis rendering but nothing which matches this one perfectly.

I opened https://bugs.webkit.org/show_bug.cgi?id=274087

@krassowski
Copy link
Member Author

bot please update snapshots

Copy link

@andrewfulton9 andrewfulton9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krassowski krassowski merged commit 0d09a9c into main May 14, 2024
6 checks passed
@krassowski krassowski deleted the resize-columns branch May 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to resize table column widths
2 participants