Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.1 updates #2

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

5.0.1 updates #2

wants to merge 18 commits into from

Conversation

elastickent
Copy link

Updated version and new paths to dependencies. Also updated the readme to include 5.0.1 build and install steps.

@jvoisin
Copy link

jvoisin commented Nov 25, 2016

Please do not bundle binary files (like .zip) inside the git repository.

@elastickent
Copy link
Author

Sure thing, thanks!

@jvoisin
Copy link

jvoisin commented Nov 28, 2016

@elastickent We're not using 5.0.1 currently, and we'd like to keep compatibility with our current used version (Kibana 2.x), and I think that this MR would break it.

What is the best practise here?
A try-catch or some kind of fallback? Doing several branches/versions?

(We're not javascript super-pro, sorry :/ )

@jvoisin jvoisin self-assigned this Nov 28, 2016
@jvoisin
Copy link

jvoisin commented Nov 30, 2016

Thank you for updating the screenshot, but can you please answer the question in my previous comment? Thank you.

@xarkes
Copy link
Contributor

xarkes commented Dec 1, 2016

Also, maybe unrelated, in the gif you added, the refresh time is different than the timing window (10 seconds vs 1 minute). Kibana is going to fetch events from last minute and do it every 10 seconds, so you are going to see the same events many time (and more than it should). I am not sure this was clearly explained in the readme file.

@elastickent
Copy link
Author

Great question. Kibana's plugin interface is not stable release to release, so separate versions seem to make the most sense to me.

Thanks for catching the timing issue in the gif.

@jvoisin
Copy link

jvoisin commented Jan 9, 2017

I don't think that we can afford to maintain several versions, especially for Kibana versions that we're not using. What about a try-catch?

@jvoisin jvoisin mentioned this pull request Jan 9, 2017
@artfulhacker
Copy link

try catch wont work in the json file. however, what I suggest is maintaining different braches and then update the readme instruction to specify the branch version when they do the git clone

@Caioha
Copy link

Caioha commented May 16, 2017

Hi

Anyone can help me?

in package.json I changed the version for 5.4.0.
I can see the mapster in visualization, I can configure, but when I try to start I receive the following message: "Visualize: Cannot read property 'group' of undefined"

@Caioha
Copy link

Caioha commented May 22, 2017

Same problem:
Visualize: Cannot read property 'group' of undefined

@purplesrl
Copy link

purplesrl commented Jan 21, 2018

Visualize: Cannot read property 'group' of undefined

Disable: Place markers off grid (use geocentroid) in Coordinates and the error goes away.

@pbr0ck3r
Copy link

pbr0ck3r commented Aug 1, 2018

Can confirm that this works on 5.2.3 as I have it running in a production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants