Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve pylint conventions and a warning #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SeungYeop-Yang
Copy link

@SeungYeop-Yang SeungYeop-Yang commented Nov 1, 2019

Update to resolve pylint conventions and a warning

The below is the results of pylint, pycodestyle, and flake8:

(setup.py) bash-3.2$ pylint setup.py 
************* Module setup
setup.py:1:0: C0114: Missing module docstring (missing-module-docstring)
setup.py:38:0: C0103: Constant name "here" doesn't conform to UPPER_CASE naming style (invalid-name)
setup.py:44:8: C0103: Constant name "long_description" doesn't conform to UPPER_CASE naming style (invalid-name)
setup.py:46:4: C0103: Constant name "long_description" doesn't conform to UPPER_CASE naming style (invalid-name)
setup.py:49:0: C0103: Constant name "about" doesn't conform to UPPER_CASE naming style (invalid-name)
setup.py:51:4: C0103: Constant name "project_slug" doesn't conform to UPPER_CASE naming style (invalid-name)
setup.py:53:8: W0122: Use of exec (exec-used)
setup.py:65:4: C0103: Argument name "s" doesn't conform to snake_case naming style (invalid-name)
setup.py:69:4: C0116: Missing function or method docstring (missing-function-docstring)
setup.py:72:4: C0116: Missing function or method docstring (missing-function-docstring)
setup.py:75:4: C0116: Missing function or method docstring (missing-function-docstring)

------------------------------------------------------------------
Your code has been rated at 7.80/10 (previous run: 7.80/10, +0.00)

(setup.py) bash-3.2$ pycodestyle setup.py 
setup.py:36:80: E501 line too long (81 > 79 characters)
setup.py:83:80: E501 line too long (86 > 79 characters)
setup.py:106:80: E501 line too long (81 > 79 characters)
(setup.py) bash-3.2$ flake8 setup.py 
setup.py:36:80: E501 line too long (81 > 79 characters)
setup.py:83:80: E501 line too long (86 > 79 characters)
setup.py:106:80: E501 line too long (81 > 79 characters)
(setup.py) bash-3.2$

This branch resolves above conventions and a warning as below:

(setup.py) bash-3.2$ pylint setup.py 

-------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 7.80/10, +2.20)

(setup.py) bash-3.2$ pycodestyle setup.py 
(setup.py) bash-3.2$ flake8 setup.py 
(setup.py) bash-3.2$

@SeungYeop-Yang SeungYeop-Yang changed the title resolve pylint conventions and warnings resolve pylint conventions and a warning Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant