Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CRUD operation on streams #72

Merged
merged 2 commits into from May 8, 2024
Merged

Add CRUD operation on streams #72

merged 2 commits into from May 8, 2024

Conversation

piotrpio
Copy link
Contributor

  • added structs and methods for operating on streams API
  • fixed a bug where request() would always wait for timeout before returning
  • added randomizing tmp directory as store_dir in natsServer.swift

Signed-off-by: Piotr Piotrowski piotr@synadia.com

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested review from Jarema and mtmk April 30, 2024 22:17
Co-authored-by: Ziya Suzen <ziya@synadia.com>
@piotrpio
Copy link
Contributor Author

piotrpio commented May 1, 2024

Note: this PR does not contain the stream/mirror external domain shenanigans, if needed I will add this separately.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@piotrpio piotrpio merged commit 851f8b5 into main May 8, 2024
3 checks passed
@piotrpio piotrpio deleted the stream-api branch May 8, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants