Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jetstream request #71

Merged
merged 4 commits into from Apr 30, 2024
Merged

Add jetstream request #71

merged 4 commits into from Apr 30, 2024

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 29, 2024

No description provided.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema marked this pull request as ready for review April 30, 2024 08:22
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -145,3 +165,11 @@ struct Ack: Codable {
duplicate = try container.decodeIfPresent(Bool.self, forKey: .duplicate) ?? false
}
}

/// contains info about the `JetStream` usage from the current account.
public struct AccountInfo: Codable {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do it in a separate PR, but this is not a full account info response

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just wanted something that I can test against.

Let's make work on it when we will add the AccountInfo PR.

@Jarema Jarema merged commit 52d9aef into main Apr 30, 2024
3 checks passed
@Jarema Jarema deleted the add-jetstream-request branch April 30, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants