Change ConsumerConfig constructor to always set default AckPolicy #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the no-args constructor for
ConsumerConfig
does not set theAckPolicy
for the consumer, which defaults it toNone
. This is confusing given that the NATS docs state that the defaultAckPolicy
isExplicit
:https://docs.nats.io/nats-concepts/jetstream/consumers#ackpolicy
This has led to unexpected behaviors since we had expected this to be set to
Explicit
by default for all consumers.This PR changes the no-args
ConsumerConfig
constructor to set theAckPolicy
toExplicit
, to be the same as the constructor with a durable name.