Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] kvStore_WatchMulti, js_Subscribe[Sync]Multi #750

Merged
merged 18 commits into from May 1, 2024
Merged

Conversation

levb
Copy link
Collaborator

@levb levb commented Apr 25, 2024

Added kvStore_WatchMulti, js_SubscribeSyncMulti, js_SubscribeMulti APIs to use multi-subject consumers.

src/js.c Show resolved Hide resolved
@levb levb changed the title WIP: [ADDED] kvStore_WatchMulti, js_SubscrubeSyncMulti [ADDED] kvStore_WatchMulti, js_Subscribe[Sync]Multi Apr 26, 2024
@levb levb marked this pull request as ready for review April 26, 2024 12:51
@levb levb requested review from kozlovic and mtmk April 26, 2024 12:51
src/util.c Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 56.38298% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 68.69%. Comparing base (559c4bc) to head (b0ad17e).

Files Patch % Lines
src/js.c 61.29% 10 Missing and 14 partials ⚠️
src/kv.c 51.72% 7 Missing and 7 partials ⚠️
src/util.c 0.00% 2 Missing ⚠️
src/mem.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   68.76%   68.69%   -0.07%     
==========================================
  Files          38       39       +1     
  Lines       15100    15176      +76     
  Branches     3119     3137      +18     
==========================================
+ Hits        10383    10425      +42     
- Misses       1681     1700      +19     
- Partials     3036     3051      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/nats.h Show resolved Hide resolved
src/nats.h Show resolved Hide resolved
src/kv.c Outdated Show resolved Hide resolved
src/js.c Outdated Show resolved Hide resolved
src/js.c Outdated Show resolved Hide resolved
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that you are going to update PR with replacement for "printStringArray", but wanted to start commenting.

src/js.c Show resolved Hide resolved
src/util.c Show resolved Hide resolved
test/test.c Show resolved Hide resolved
test/test.c Show resolved Hide resolved
test/test.c Show resolved Hide resolved
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb merged commit 3f02b1d into main May 1, 2024
15 checks passed
@levb levb deleted the lev-KVWatch-subjects branch May 1, 2024 17:30
github-actions bot pushed a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants