Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] Build with github actions #669

Closed
wants to merge 16 commits into from
Closed

[ADDED] Build with github actions #669

wants to merge 16 commits into from

Conversation

levb
Copy link
Collaborator

@levb levb commented Jul 10, 2023

Moved the build system from Travis to GitHub actions.

There are 2 main jobs:

  • debug runs test coverage and sanitize with gcc, in debug mode; it also runs debug-compiled tests on clang and latest/LTS Ubuntu versions.
  • release compiles in release mode, and tests various server versions, and packaging options (no TLS, no streaming)

PRs run debug by default. If you want to run the release build on a PR before merging it, set the build-release on it.

NOTE that since I added a "catch all" for thread sanitizer warnings, many tests have been failing in that mode both on travis and github workflows, so I filed #672 and skipped them in the sanitize=thread mode.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@e30991e). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage        ?   78.77%           
=======================================
  Files           ?       40           
  Lines           ?    33915           
  Branches        ?     4774           
=======================================
  Hits            ?    26717           
  Misses          ?     2836           
  Partials        ?     4362           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

-Werror

test_VersionTag checks GITHUB_TAG

trigger differently

proper sanitize thread failure detection

limit on push to main/release

exclude sanitize=thread flappers

exclude sanitize=thread flappers, fixed

reduced diffs
@levb levb requested a review from wallyqs July 11, 2023 12:03
@levb levb changed the title WIP: [ADDED] Build with github actions [ADDED] Build with github actions Jul 11, 2023
@levb levb marked this pull request as ready for review July 11, 2023 12:06
@levb levb requested review from Jarema and mtmk July 11, 2023 12:14
Copy link
Contributor

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb closed this Apr 23, 2024
@levb levb deleted the gh-action-build branch April 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants