Document struct field names in stream.go #5359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmoyne
force-pushed
the
jnm/comments1
branch
3 times, most recently
from
5760bf3
to
675e1cb
Compare
|
Thank you for doing this! As someone external to the Nats Core team who code reviews every PR acquiring knowledge, this is really valuable. I wish the codebase had become more verbose in terms of spelling names and introduced even more types to reflect the domain as well 🙏🏻 Regardless, this is super valuable! |
derekcollison
requested changes
Apr 26, 2024
|
Hey @jnmoyne can you rebase on top of main and resolve one conflict with your sourcing change? |
|
Once resolved I will pull in. |
…improve the code accessibility. Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
|
Rebased |
wallyqs
pushed a commit
that referenced
this pull request
May 1, 2024
- Add comments to document main structure field names a bit better and improve the code accessibility. - Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
wallyqs
pushed a commit
that referenced
this pull request
May 1, 2024
- Add comments to document main structure field names a bit better and improve the code accessibility. - Rename setSourceConsumer to setupSourceConsumer (better and matches setupMirrorConsumer). Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com> --------- Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jean-Noël Moyne jnmoyne@gmail.com