Cherry-pick PRs for 2.10.15-RC.3 #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Waldemar Quevedo <wally@nats.io>
I made an incorrect comment previously about not needing to check the cache's result to know if there is a match. I added a test for that, but also discovered that there was an issue where HasInterest would incorrectly return true if checking for "foo" when there is only a subscription on "foo.*". Added more tests. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Co-authored-by: Jean-Noël Moyne <jnmoyne@gmail.com>
If the first INFO never makes it back and for some reasons the remote also does not close the connection, or connection is half closed, the outbound would not have detected that the connection is stale. The outbound connection cannot send PING before it receives the INFO from the remote because that is only when the outbound sends the CONNECT. But the remote will fail if the first protocol from an outbound is not CONNECT. Using the same principle that we used for routes with compression enabled, where PINGs cannot be sent until a certain time in the handshake, we will use the ping timer to simply close the connection as stale if the ping timer has not been reset before the time needed to send the max number of pings. Resolves #5349 Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
We had a bug that would overwrite the sync subject during parallel stream creation which would cause upper layer stream cacthups to fail on server restarts. We also were reporting first sequence mismatch when we hot max retries to force a reset but this was misleading, so added in proper error for max retires limit. Signed-off-by: Derek Collison <derek@nats.io>
Consumers could still be catching up as well. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…heck if beyond a minumum threshold. On an active stream the ack floor periodic checks could trigger just due to normal circumstances, so use minimum threshold. Also do not jump delivered in that logic based on stream sequences. And finally do not have leader jump ack floors when pending is empty, this allows consistency checks to be consistent across all replicas. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
(*Sublist).HasInterest()#5353Signed-off-by: Neil Twigg neil@nats.io