Add pedantic mode #5245
Open
Add pedantic mode #5245
+472
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
requested changes
Apr 10, 2024
Jarema
force-pushed
the
pedantic
branch
2 times, most recently
from
f6623a7
to
b9165ad
Compare
Pedantic mode intention has been added to all paths. Now it need to be properly handled and tested Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
ripienaar
requested changes
May 11, 2024
| @@ -36,6 +36,14 @@ import ( | |||
| "github.com/nats-io/nuid" | |||
| ) | |||
|
|
|||
| // StreamRequest is used to create or update a stream. | |||
| type StreamRequest struct { | |||
There was a problem hiding this comment.
We have CreateConsumerRequest which seems very clear, where StreamRequest seems ambigious - we have many other kinds of stream request other than create/update. So maybe a better for this would be nice.
| Stream string `json:"stream_name"` | ||
| Config ConsumerConfig `json:"config"` | ||
| Action ConsumerAction `json:"action"` | ||
| Pedantic bool `json:"pedantic"` |
There was a problem hiding this comment.
we could probably make this omitempty also same as in the stream one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pedantic mode as requested in #4959
Draft, as I need to make sure all cases are covered and tested.
I also want to check if the amount of changes in arguments passed to assigment functions could be reduced.
Signed-off-by: Tomasz Pietrek tomasz@nats.io