Add observer to peer info
#481
Merged
+66
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Sep 26, 2023
api/cluster.go
Outdated
| Lag uint64 `json:"lag,omitempty" yaml:"lag"` | ||
| Name string `json:"name" yaml:"name"` | ||
| Current bool `json:"current" yaml:"current"` | ||
| Observer bool `json:"observer" yaml:"observer"` |
There was a problem hiding this comment.
I noticed you did omitempty in json on the nats.go so we should probably do the same here? Assuming thats whats in the server. But not on yaml.
There was a problem hiding this comment.
Yes good catch, fixed.
ripienaar
requested changes
Sep 26, 2023
This is to support nats-io/nats-server#4582. Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/observers
branch
from
6fb84b8
to
e6fda16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support nats-io/nats-server#4582.
Signed-off-by: Neil Twigg neil@nats.io