Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch to global object in dev env #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

akellbl4
Copy link

Hi
I tried to use fetch inside getStaticProps and it just doesn't work in dev (for build it works just fine because it is imported by add fetch on transformation).
I'm not sure if node-fetch should be injected for that situation with other tools but I just tried to put fetch in nodejs global object for microsite dev.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2021

⚠️ No Changeset found

Latest commit: d5945e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

microsite-examples – ./

🔍 Inspect: https://vercel.com/nmoo/microsite-examples/FhQifQKwxL2zGJ2ngyz3EMU6tuTV
✅ Preview: https://microsite-examples-git-fork-akellbl4-add-fetch-in-dev-nmoo.vercel.app

microsite – ./site

🔍 Inspect: https://vercel.com/nmoo/microsite/FekUnUgVrmmPZxU65dtADUZPZSD9
✅ Preview: Canceled

@akellbl4
Copy link
Author

@natemoo-re feel free to correct me. I don't know how it should work, maybe I just did something unnecessary :)

@natemoo-re
Copy link
Owner

Thanks for the ping. I'll double check on this later tonight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants