New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] Fix for why Open MCT goes blank sometimes #7649
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7649 +/- ##
==========================================
- Coverage 49.13% 49.11% -0.03%
==========================================
Files 671 671
Lines 27116 27116
Branches 2632 2632
==========================================
- Hits 13324 13318 -6
- Misses 13464 13470 +6
Partials 328 328
see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
7ffc355
to
713b969
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting width: 0
on the grid item details element (line 111, grid-view.scss) to fix the text overwriting problem is not the way to solve this. Instead, the __details class needs to have overflow: hidden
on it. This then allows the ellipsizing that's applied to the __name div inside to work properly. I tested, and you can just add the overflow property to the base CSS for __details - it doesn't need to be mobile-only.
Everything else looks great, good to go with the correction above.
Closes #7320
Describe your changes:
All Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist