Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WV-3174 Provide ability to set default number of granules to display on a per layer basis #5202

Merged
merged 4 commits into from
May 17, 2024

Conversation

PatchesMaps
Copy link
Contributor

@PatchesMaps PatchesMaps commented May 15, 2024

Description

Provide ability to set the default/initial number of granules displayed in Worldview on a per-layer basis.

How To Test

  1. git checkout WV-3079-default-num-granules
  2. In worldview/config/default/common/config/wv.json/layers/viirs/noaa20/VIIRS_NOAA20_CorrectedReflectance_TrueColor_Granule.json add "count": 1
  3. npm run build
  4. npm run watch
  5. Open this link
  6. Only one granule should be visible by default

PR Submission Checklist

This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • Any dependent changes have been merged and published in downstream modules (if applicable)

Merging

Please use the squash and merge commit method unless each commit in your branch is vital to the commit history of main.

@nasa-gibs/worldview

@PatchesMaps PatchesMaps self-assigned this May 15, 2024
@PatchesMaps PatchesMaps removed the request for review from Tomcariello May 15, 2024 20:19
@PatchesMaps PatchesMaps marked this pull request as draft May 16, 2024 13:07
@PatchesMaps PatchesMaps marked this pull request as ready for review May 16, 2024 13:18
@minniewong
Copy link
Contributor

Can you add this parameter to the documentation? https://github.com/nasa-gibs/worldview/blob/main/doc/config/layers.md and anywhere else you see fit.

@minniewong minniewong added this to the v4.38.0 milestone May 16, 2024
@PatchesMaps PatchesMaps merged commit 79f0326 into develop May 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants