use --arch for ops pkg push cmd (with sanitisation for amd64) #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radiosilence
changed the title
radiosilence
force-pushed
the
feature/ops-push-arch
branch
from
60ced36
to
36df121
Compare
radiosilence
force-pushed
the
feature/ops-push-arch
branch
from
36df121
to
5e69082
Compare
eyberg
reviewed
Apr 26, 2024
| @@ -623,7 +624,7 @@ func pushCommandHandler(cmd *cobra.Command, args []string) { | |||
| } | |||
| defer os.RemoveAll(archiveName) | |||
|
|
|||
| req, err := api.BuildRequestForArchiveUpload(ns, name, foundPkg, archiveName, private) | |||
| req, err := api.BuildRequestForArchiveUpload(ns, name, foundPkg, archiveName, private, arch) | |||
There was a problem hiding this comment.
can you change this to pkgFlags.Parch() ?
then I believe you can get rid of the arch flag above as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically this completes the loop for pushing packages with multiple arches via CLI.
Seeing as the current
--archflag accepts eitheramd64(as opposed tox86_64) orarm64, I'm manually changing this in the request data when it's pushed to the repo.Also falls back to
x86_64if it's blank/unsetAlso it slightly changes the behaviour when searching local packages, as previously it was erroring out if one of the existing arches didn't exist yet, so we just log it and continue instead.