Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes surprising possible ordering of nng_pipe_notify events. #961

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes surprising possible ordering of nng_pipe_notify events. #961

wants to merge 1 commit into from

Commits on Jun 12, 2019

  1. Fixes surprising possible ordering of nng_pipe_notify events. 

    On nng_pipe_notify events, it was possible for events to fire in an
unexpected order: pre-connect, post-*remove*, and finally
post-*connect*.  This can cause errors in the wild if a resource is
attained in pre-connect and released in post-remove, as the resource
cannot be used in the post-connect event if the race is exercised.

Now, events will fire strictly in the order of pre-connect,
post-connect, and post-remove.  If the pipe is closed in
pre-connect, post-connect and post-remove will not be called.
    @codypiersall
    codypiersall committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    65b79e9 View commit details
    Browse the repository at this point in the history