Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Clang-Tidy #1014

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Clang-Tidy #1014

wants to merge 2 commits into from

Conversation

hugolm84
Copy link
Contributor

This PR adds support for Clang-Tidy by simply passing -DCLANG_TIDY=ON when configuring CMake.
If you want to let Clang-Tidy try to fix the suggestions, warnings and errors Automagically™ just pass -DCLANG_TIDY_FIX=ON.

Build as usual using cmake --build . (or ninja, make etc)

I took the liberty to choose the clang-tidy checks at my own liking. Should any of them not be suitable for this project, please comment.

Tested on Linux, OSX and Windows.

Note that the above format should be used in your git commit comments.
You agree that by submitting a PR, you have read and agreed to our
contributing guidelines.

@gdamore
Copy link
Contributor

gdamore commented Nov 12, 2019

I'll have a go at this -- I want to test it out for myself before I merge.

@gdamore
Copy link
Contributor

gdamore commented Dec 28, 2019

Mostly this is on hold waiting for me to review and assess.
I'm using a clang-tidy integration with my editor now, which is helping, along with checks being done via LGTM during the PR process.

@gdamore
Copy link
Contributor

gdamore commented May 24, 2020

I've not forgotten about this PR -- it's not a huge priority for me however. I will probably work towards getting something based on this work in later -- I really want to clean up the mess that is our CMake support first though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants