Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/gorilla/websocket from 1.5.0 to 1.5.1 #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps github.com/gorilla/websocket from 1.5.0 to 1.5.1.

Release notes

Sourced from github.com/gorilla/websocket's releases.

Release v1.5.1

What's Changed

New Contributors

Full Changelog: gorilla/websocket@v1.5.0...v1.5.1

Commits
  • ac0789b update GitHub workflows (#857)
  • 78c3487 update golang.org/x/net (#856)
  • 666c197 Update go version & add verification/testing tools (#840)
  • 8039329 Correct way to save memory using write buffer pool and freeing net.http defau...
  • 8983b96 Merge pull request #839 from gorilla/coreydaley-patch-1
  • 931041c Update README.md
  • 76ecc29 archive mode
  • af47554 check error before GotConn for trace
  • bc7ce89 Check for and report bad protocol in TLSClientConfig.NextProtos (#788)
  • 27d91a9 drop the versions of go that are no longer supported + add 1.18 to ci
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf5e1c7) 99.94% compared to head (6849d7b) 99.94%.
Report is 4 commits behind head on master.

❗ Current head 6849d7b differs from pull request most recent head 8df91c1. Consider uploading reports for the commit 8df91c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          49       49           
  Lines        7033     7033           
=======================================
  Hits         7029     7029           
  Misses          3        3           
  Partials        1        1           
Flag Coverage Δ
unittests 99.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdamore
Copy link
Contributor

gdamore commented Feb 17, 2024

@dependabot rebase

Bumps [github.com/gorilla/websocket](https://github.com/gorilla/websocket) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/gorilla/websocket/releases)
- [Commits](gorilla/websocket@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: github.com/gorilla/websocket
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/gorilla/websocket-1.5.1 branch from 6849d7b to 8df91c1 Compare February 17, 2024 23:36
@gdamore
Copy link
Contributor

gdamore commented Feb 17, 2024

So it appears that we would need to restrict ourselves to go version 1.20 or higher. I'm not sure I'm prepared to accept that limitation/requirement as it will impact my down streams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant