Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #198 negative send/receive deadlines do not work #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdamore
Copy link
Contributor

@gdamore gdamore commented Sep 27, 2020

This actually affected pretty much all the protocols and both send
and receive deadlines. While here we've also made sure that
a non-blocking check will not fail if a message can immediately
be sent or received.

This actually affected pretty much all the protocols and both send
and receive deadlines.  While here we've also made sure that
a non-blocking check will not fail if a message can immediately
be sent or received.
@codecov
Copy link

codecov bot commented Sep 27, 2020

Codecov Report

Merging #216 into master will decrease coverage by 0.38%.
The diff coverage is 98.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #216      +/-   ##
===========================================
- Coverage   100.00%   99.61%   -0.39%     
===========================================
  Files           46       43       -3     
  Lines         6584     4978    -1606     
===========================================
- Hits          6584     4959    -1625     
- Misses           0       15      +15     
- Partials         0        4       +4     
Flag Coverage Δ
#unittests 99.61% <98.30%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
protocol/xbus/xbus.go 98.78% <85.71%> (-1.22%) ⬇️
protocol/xreq/xreq.go 98.05% <91.66%> (-1.95%) ⬇️
protocol/rep/rep.go 100.00% <100.00%> (ø)
protocol/req/req.go 100.00% <100.00%> (ø)
protocol/respondent/respondent.go 98.89% <100.00%> (-1.11%) ⬇️
protocol/sub/sub.go 99.47% <100.00%> (-0.53%) ⬇️
protocol/surveyor/surveyor.go 99.15% <100.00%> (-0.85%) ⬇️
protocol/xpair/xpair.go 100.00% <100.00%> (ø)
protocol/xpull/xpull.go 100.00% <100.00%> (ø)
protocol/xpush/xpush.go 100.00% <100.00%> (ø)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b0da2...4d69051. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant