Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update return type and type hints #1811

Closed
wants to merge 6 commits into from

Conversation

dcblogdev
Copy link
Collaborator

No description provided.

@solomon-ochepa
Copy link
Contributor

image

There are a few bugs that require attention.

For instance, the property in src/Activators/FileActivator.php, along with several others, has been identified as having two data types, both of which are formatted incorrectly.

Actual:

    /**
     * Laravel Filesystem instance
     *
     * @var Filesystem
    */
    private mixed $files;

Correction:

    /**
     * Laravel Filesystem instance
    */
    private mixed $files;

Contrary to my previous interaction, not all properties and methods are of mixed types; rather, they each have a specific, precise type.

@solomon-ochepa
Copy link
Contributor

I was hoping to assist with this; fortunately, you're already on it. The codebase requires some cleanup.

@dcblogdev
Copy link
Collaborator Author

Yeah this is very much a wip not everything is correct yet

@dcblogdev dcblogdev marked this pull request as draft April 25, 2024 12:38
@dcblogdev dcblogdev closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants