added DynamoDb driver #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nWidart
reviewed
Dec 21, 2018
LavaToaster
reviewed
Dec 21, 2018
| $secretAccessKey = $this->config->get('broadway.event-store.secret_access_key', ''); | ||
| $region = $this->config->get('broadway.event-store.region', ''); | ||
|
|
||
| $credentials = new Credentials($accessKeyId, $secretAccessKey); |
There was a problem hiding this comment.
My only issue around this is where in my company we don't configure our applications with AWS access / secret keys. We use EC2 IAM Roles, which allows the applications to pull out secret keys dynamically from the EC2 Metadata service.
There was a problem hiding this comment.
Yeah, I thought to integrate another access manager where you can use secert keys or EC2 IAM Roles, it could be a new next feature @Lavoaster ?
|
Any news for this pull request @nWidart ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.