fix: store console files in subdirectory of iroh data dir #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
fix-console-dirs
branch
5 times, most recently
from
2cf6484
to
84efbd1
Compare
dignifiedquire
approved these changes
May 16, 2024
Frando
force-pushed
the
feat/default-author
branch
2 times, most recently
from
bf6a6ae
to
8e5c238
Compare
|
@Frando meeeerge conflicts |
dignifiedquire
force-pushed
the
feat/default-author
branch
from
b463910
to
5ccdf0b
Compare
Frando
force-pushed
the
feat/default-author
branch
from
7fbaccf
to
62423aa
Compare
|
@dignifiedquire rebased |
dignifiedquire
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We used to store the console files (history and current author) in a subdirectory
consoleunder the iroh data dir. This got lost in some refacorings, and the console files currently are created in the iroh data directory directly.This is bad because the iroh data directory is a single namespace, and we should use it cautiously.
This PR goes back to using a
consolesubdirectory. Existing files are migrated on first start of the console.Based on #2299 because this already made the environment init functions async.
Breaking Changes
Notes & open questions
Change checklist