Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: experiment with collections #2272

Closed
wants to merge 3 commits into from
Closed

Conversation

dignifiedquire
Copy link
Contributor

No description provided.

Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of removing the concept of collections from iroh-bytes iroh-blobs.

Other than moving things around this does not seem to change anything fundamentally.

iroh/src/util/collection.rs Show resolved Hide resolved
@dignifiedquire dignifiedquire added this to the v0.17.0 milestone May 15, 2024
@dignifiedquire dignifiedquire self-assigned this May 15, 2024
@dignifiedquire dignifiedquire removed this from the v0.17.0 milestone May 21, 2024
@rklaehn
Copy link
Contributor

rklaehn commented Jun 5, 2024

I like the idea to move collection out of iroh-bytes. Also the idea of moving the export logic to the client side of the rpc boundary.

But I don't like moving it into iroh.

You should be able to work with collections without having to import all of iroh, including gossip, docs, ... Collections are fundamentally an iroh-blobs concept.

  • So I would say: keep the simplification of the export API
  • Keep collections in iroh-blobs under a feature flag, or move them into a separate crate, but not in iroh

WDYT?

@dignifiedquire
Copy link
Contributor Author

how would you implement them then over RPC? if in iroh-blobs implemented, the only trait it can know about is the Store parts, but that is not enough to move them to client only, which the follow on step for me would be

@rklaehn rklaehn closed this Jun 6, 2024
@dignifiedquire dignifiedquire deleted the iroh-collection branch June 6, 2024 13:14
github-merge-queue bot pushed a commit that referenced this pull request Jun 6, 2024
…e client side (#2349)

## Description

A collection is just one particular way to use a hashseq, so it feels a
bit weird to have it baked in to the iroh node. With this we can move
some of it into the client.

This is a part of #2272 . We can
make more similar changes once we have the batch API
#2339 .

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

Note: I closed #2272 because half of the changes in that PR are here,
the other half will be part of the batch PR, and moving collections into
iroh I am not convinced of yet...

## Change checklist

- [x] Self-review.
- [x] Documentation updates if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants