-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]: experiment with collections #2272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of removing the concept of collections from iroh-bytes iroh-blobs.
Other than moving things around this does not seem to change anything fundamentally.
I like the idea to move collection out of iroh-bytes. Also the idea of moving the export logic to the client side of the rpc boundary. But I don't like moving it into iroh. You should be able to work with collections without having to import all of iroh, including gossip, docs, ... Collections are fundamentally an iroh-blobs concept.
WDYT? |
how would you implement them then over RPC? if in |
…e client side (#2349) ## Description A collection is just one particular way to use a hashseq, so it feels a bit weird to have it baked in to the iroh node. With this we can move some of it into the client. This is a part of #2272 . We can make more similar changes once we have the batch API #2339 . ## Breaking Changes <!-- Optional, if there are any breaking changes document them, including how to migrate older code. --> ## Notes & open questions Note: I closed #2272 because half of the changes in that PR are here, the other half will be part of the batch PR, and moving collections into iroh I am not convinced of yet... ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
No description provided.