feat: iroh-perf #2186
Merged
feat: iroh-perf #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iroh-net/bench/Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "iroh-net-bench" | |||
| version = "0.16.0" | |||
| version = "0.13.0" | |||
dignifiedquire
approved these changes
May 22, 2024
flub
approved these changes
May 22, 2024
iroh-net/bench/src/quinn.rs
Outdated
Comment on lines
89
to
90
| .context("connecting") | ||
| .unwrap(); |
There was a problem hiding this comment.
This won't do anything, you probably want .expect("connecting") instead.
iroh-net/bench/src/lib.rs
Outdated
Comment on lines
225
to
226
| stats.upload_stats.total_duration = start.elapsed(); | ||
| stats.download_stats.total_duration = start.elapsed(); |
There was a problem hiding this comment.
maybe move this up to right after acquire_many()? Probably not a big difference though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In progress thing for what should later be
iroh-perf. For now you can run withcargo run --release -- irohandcargo run --release -- quinnto do a simple comparison benchmark.More knobs are available for tuning with
--help.There's a much more stark difference on macOS compared to running on Linux.
Next steps bumping to test against
quinn 0.11Sample output:
Notes & open questions
Change checklist