Support excluding buffers by name, to support Buffergator and fix #48 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, items in the g:numbers_exclude list were only checked against the filetype of a buffer. This worked great with, say, NERDTree, which sets the filetype of its file tree buffers to "nerdtree". However, plugins like Buffergator don't set the filetype of their buffers. They do, however, set the buffer title. numbers.vim now checks the items in g:numbers_exclude against both the filetype of a buffer, and its name. This commit also adds "[[buffergator-buffers]]" to the default g:numbers_exclude list. These two changes should cause numbers.vim to exclude Bugffergator windows by default.
|
@int3h Thanks for the pull request, I have you tested 7.3 and 7.4 versions of vim? |
|
It works for me on 7.4 |
|
Closing old pull requests to clean up my GH 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes how numbers.vim checks buffers against g:numbers_exclude.
Previously, buffers were only checked by their filetype against g:numbers_exclude. This meant plugins like Buffergator, which don't set the filetype of their buffers, could not be excluded, as detailed in #48.
numbers.vim now checks buffers by both filetype and name against g:numbers_exclude. It also adds "[[buffergator-buffers]]" (the name of Buffergator buffers) to the default value of g:numbers_exclude.
These two changes now means numbers.vim plays nicely with Buffergator, and similar plugins.