Deal better with plan downgrades. #1382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracos
force-pushed
the
api-downgrade
branch
2 times, most recently
from
847fd42
to
c18166e
Compare
struan
approved these changes
Sep 6, 2018
| if ($form_data['coupon']) { | ||
| $this->stripe->coupon = $form_data['coupon']; | ||
| } elseif ($this->stripe->discount) { | ||
| $this->stripe->deleteDiscount(); | ||
| } | ||
|
|
There was a problem hiding this comment.
It'd be nice to have a comment in here with either an explanation of what this is for or a link to one because trying to derive it all from code isn't easy :)
classes/Subscription.php
Outdated
| } else { | ||
| # An upgrade higher than where they started the month - upgrade | ||
| # back to the original without proration, then upgrade to new | ||
| # plan from there, removing the old maximum_plan. |
There was a problem hiding this comment.
Would be useful to mention in here that this is because stripe doesn't handle this case so need to do two step.
dracos
force-pushed
the
api-downgrade
branch
from
c18166e
to
8a9e357
Compare
dracos
force-pushed
the
master
branch
6 times, most recently
from
e38971a
to
779d185
Compare
dracos
force-pushed
the
master
branch
9 times, most recently
from
0ecdd22
to
59a2af8
Compare
dracos
force-pushed
the
master
branch
5 times, most recently
from
8c1c8bc
to
9611368
Compare
dracos
force-pushed
the
master
branch
2 times, most recently
from
f880855
to
d17f6a3
Compare
dracos
force-pushed
the
master
branch
2 times, most recently
from
152a3d0
to
89dc131
Compare
dracos
force-pushed
the
master
branch
5 times, most recently
from
c792d3a
to
af10fb2
Compare
dracos
force-pushed
the
master
branch
6 times, most recently
from
bc5c83e
to
9ed6db5
Compare
dracos
force-pushed
the
master
branch
2 times, most recently
from
5d1c590
to
1ccc60d
Compare
dracos
force-pushed
the
master
branch
7 times, most recently
from
81c138e
to
7328522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/mysociety/better-cities/issues/19 for full discussion. I keep asking myself if I've missed something obvious but it doesn't seem so. Perhaps you will spot/think of something.
If the logic seem okay, will copy to MapIt and add tests there, probably easier place for them.