allow redirect to policy page from postcode page #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
struan
force-pushed
the
issues/1248-redirect-after-postcode
branch
from
05eb06f
to
37929db
Compare
Used if we need to pass extra things like policy numbers along to the postcode page
Used for linking to policy sets from outside TWFY, e.g. from social media.
Allow a different title on the postcode page for e.g. cases where we will be redirecting afterwards and we want to reassure the user that this is part of the process.
If we are redirecting to a policy or policy set then change the title of the postcode form to mention the policy/set to reassure the user they are on the right track.
The test framework runs under CLI which means the headers aren't printed so we can't test redirects. To get round this check if we are running under the CLI and then print out the header.
struan
force-pushed
the
issues/1248-redirect-after-postcode
branch
from
37929db
to
63431d6
Compare
Add postcode_lookup rows in fixtures for tests that do postcode lookupts so that: * tests run offline * we don't have problems with mapit quotas
struan
changed the title
It was unlikely that anyone would see this page before because it would only be linked to if the MP had voted. Now that we can redirect to this page it's more likely that it will be seen so tidy it up a bit.
dracos
force-pushed
the
master
branch
4 times, most recently
from
2012ddf
to
9813413
Compare
dracos
force-pushed
the
master
branch
7 times, most recently
from
f82bb7e
to
aac1a80
Compare
dracos
force-pushed
the
master
branch
4 times, most recently
from
c858a71
to
5ddba3b
Compare
dracos
force-pushed
the
master
branch
2 times, most recently
from
152a3d0
to
89dc131
Compare
dracos
force-pushed
the
master
branch
5 times, most recently
from
c792d3a
to
af10fb2
Compare
dracos
force-pushed
the
master
branch
6 times, most recently
from
bc5c83e
to
9ed6db5
Compare
dracos
force-pushed
the
master
branch
2 times, most recently
from
5d1c590
to
1ccc60d
Compare
dracos
force-pushed
the
master
branch
7 times, most recently
from
81c138e
to
7328522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specify a policy set or policy to visit after the user has set their postcode at
/postcodeso that we can link to a policy from e.g. social media.By adding either
?policy_set=socialor?policy_number=6710the postcode page will redirect to the relevant policy set or policy page for the MP.If the user is in Scotland or Northern Ireland the choose representative page isn't shown as we only have policies for MPs so offering them a choice to see an MSP or MLA isn't going to be useful.
There's also a change to the postcode form title to indicate that putting in a postcode is part of the process of getting the information.
Fixes #1248