[Whitespace] Add extra logging to Whitespace call method #4958
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4958 +/- ##
=======================================
Coverage 82.59% 82.59%
=======================================
Files 393 393
Lines 30653 30655 +2
Branches 4846 4846
=======================================
+ Hits 25319 25321 +2
- Misses 3891 3892 +1
+ Partials 1443 1442 -1 ☔ View full report in Codecov by Sentry. |
| @@ -34,7 +36,12 @@ has endpoint => ( | |||
| soapversion => 1.1, | |||
| proxy => $self->url, | |||
| default_ns => $self->attr, | |||
| on_action => sub { $self->attr . $_[1] } | |||
| on_action => sub { $self->attr . $_[1] }, | |||
| on_fault => sub { | |||
There was a problem hiding this comment.
Looking at open311-adapter, it looks like $res might not be an object sometimes (at least they always check there), don't know if that can happen here or not. Also the default in SOAP::Lite appears to return $res rather than die, not sure if that matters either.
Instead of this, could we perhaps add the logging where it says "TODO: Better error handling" - that should always get a response, success or failure, I think, so you could log any failure there?
We're seeing some 400 errors from Whitespace, so this should help us pin down which method call is causing those errors.