[Merton] Flat above shop changes #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## merton-ww-initial #4957 +/- ##
==================================================
Coverage 82.64% 82.65%
==================================================
Files 397 397
Lines 30799 30808 +9
Branches 4861 4867 +6
==================================================
+ Hits 25453 25463 +10
+ Misses 3896 3895 -1
Partials 1450 1450 ☔ View full report in Codecov by Sentry. |
nephila-nacrea
approved these changes
May 14, 2024
| @@ -344,10 +344,23 @@ FixMyStreet::override_config { | |||
| is $report->category, 'Request new container'; | |||
| is $report->title, 'Request new Recycling Blue Stripe Bag'; | |||
| }; | |||
| subtest 'Weekly collection cannot request a blue stripe bag' => sub { | |||
| subtest 'Above-shop address' => sub { | |||
| $e->mock('GetServiceUnitsForObject', sub { $above_shop_data }); | |||
| $mech->get_ok('/waste/12345/request'); | |||
There was a problem hiding this comment.
Have added some basic tests.
This took me far too long because I hadn't noticed this bit was fetching '/waste/12345/request' and not ''/waste/12345' and I kept wondering why I wasn't getting the expected output 🤦♀️
dracos
force-pushed
the
merton-ww-initial-fas-changes
branch
from
c030852
to
4ba55d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip changelog]
Fixes https://github.com/mysociety/societyworks/issues/4310
Looks like this for me:
