Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bexley] Missed collection can't be reported until round confirmed #4932

Merged
merged 12 commits into from
Jun 3, 2024
Merged

[Bexley] Missed collection can't be reported until round confirmed #4932

merged 12 commits into from
Jun 3, 2024
+380 −93

Commits on Jun 3, 2024

  1. [Bexley] Missed collection can't be reported until round confirmed 

    Need to check when the cab logs say the round was finished
before allowing missed reports on services

https://3.basecamp.com/4020879/buckets/35109031/todos/7283503961
    @MorayMySoc @chrismytton
    MorayMySoc authored and chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    124e020 View commit details
    Browse the repository at this point in the history

  2. [Bexley][WW] Remove old code for 'report_open' 

    Was overriding the newer logic before it; was accidentally left in.
    @nephila-nacrea @chrismytton
    nephila-nacrea authored and chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fb0f0f8 View commit details
    Browse the repository at this point in the history

  3. [Bexley] Use red tag logs to signal round completion

    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    045bbbf View commit details
    Browse the repository at this point in the history

  4. [Bexley] Missed bins can be reported after collection complete 

    Missed bins can be reported on the day of collection once the round has
been completed.
    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    479f862 View commit details
    Browse the repository at this point in the history

  5. [Bexley] Check last collection was within the working days window

    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8fb6df1 View commit details
    Browse the repository at this point in the history

  6. [Bexley] Allow missed collection reports on day of collection 

    Update the logic which checks we're outside the reporting window to
check if the collection is happening today, and if it is then proceed
with the missed collection checks.
    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f638e7a View commit details
    Browse the repository at this point in the history

  7. [Bexley] Show delayed message after 5pm

    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6fc55cd View commit details
    Browse the repository at this point in the history

  8. [Bexley] Associate red-tags with specific containers

    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6f40472 View commit details
    Browse the repository at this point in the history

  9. [Bexley][WW] Fetch USRN for property from LLPG database 

    We were looking up the USRN cab logs using the USRN value from
the first UPRN log returned. But if there are no UPRN logs,
there is no USRN value, and therefore *all* logs are requested.
This causes bugs / timeouts.
    @nephila-nacrea @chrismytton
    nephila-nacrea authored and chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8c7945d View commit details
    Browse the repository at this point in the history

  10. [Bexley][Whitespace] Use combination of LogID + Reason for unique logs 

    LogID isn't unique, a report of Food - Not Out and Paper & Card - Not
Out results in two log entries which both have the same LogID, but
different reasons, so use the reason when making logs unique.

Also adds an extra check to ensure the round matches when looking for
relevant logs.
    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2168629 View commit details
    Browse the repository at this point in the history

  11. [Bexley] Check red tags and service exceptions separately 

    The concept of "round exceptions" doesn't really make sense. Instead
we're dealing with service exceptions (problems accessing the street,
for example) and red tags (which are on a specific container). So do
these as two separate checks, one on the propery, one on the service,
when determining if a missed collection can be reported.
    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f721c74 View commit details
    Browse the repository at this point in the history

  12. [Bexley] Hide garden waste promo on properties with no collections

    @chrismytton
    chrismytton committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9aed7b2 View commit details
    Browse the repository at this point in the history