[Bromley][WW] Send multiple photos through on all categories #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4918 +/- ##
===========================================
- Coverage 82.61% 69.01% -13.60%
===========================================
Files 390 42 -348
Lines 30473 5080 -25393
Branches 4812 0 -4812
===========================================
- Hits 25174 3506 -21668
+ Misses 3862 1574 -2288
+ Partials 1437 0 -1437 ☔ View full report in Codecov by Sentry. |
chrismytton
approved these changes
Apr 11, 2024
When adding the comment data to the notes field include the user details with the comment in the format requested mysociety/societyworks#4232
Turns out not all, only the Echo ones.
mysociety-pusher
force-pushed
the
4233-bromley-send-multiple-photos
branch
from
cdc9de9
to
ef63991
Compare
|
This was actually for merging into #4869 which is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sending of photos for all categories. Assume all Waste is Echo. Echo set up for receiving photos but think general open311 just receiving urls
https://github.com/mysociety/societyworks/issues/4233
[skip changelog]