Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merton] Initial WasteWorks setup. #4902

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

[Merton] Initial WasteWorks setup. #4902

wants to merge 9 commits into from

Conversation

dracos
Copy link
Member

@dracos dracos commented Mar 28, 2024

After the Echo refactoring, this is hopefully quite a bit smaller than it would have been previously.
This contains the core report/request functionality, basics thereof, with quite a bit shared with SLWP, so factored that out to a separate shared file.
https://github.com/mysociety/societyworks/issues/4224
https://github.com/mysociety/societyworks/issues/4225
https://github.com/mysociety/societyworks/issues/4226
[skip changelog]

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 89.93289% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 82.64%. Comparing base (0e27af4) to head (0c9bf34).

Files Patch % Lines
perllib/FixMyStreet/Cobrand/Merton/Waste.pm 88.40% 5 Missing and 3 partials ⚠️
perllib/FixMyStreet/Script/Merton/SendWaste.pm 89.47% 1 Missing and 5 partials ⚠️
perllib/FixMyStreet/Roles/Cobrand/Echo.pm 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4902      +/-   ##
==========================================
+ Coverage   82.58%   82.64%   +0.05%     
==========================================
  Files         393      397       +4     
  Lines       30652    30799     +147     
  Branches     4846     4861      +15     
==========================================
+ Hits        25315    25453     +138     
- Misses       3894     3896       +2     
- Partials     1443     1450       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the merton-ww-initial branch 3 times, most recently from cbe92c6 to 24328cc Compare April 9, 2024 17:03
@dracos dracos changed the base branch from echo-refactoring to master April 10, 2024 14:11
@dracos dracos requested a review from chrismytton April 10, 2024 14:13
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple of comments, but nothing that should block merging or require re-review.

t/app/controller/waste_merton.t Outdated Show resolved Hide resolved
perllib/FixMyStreet/Roles/CobrandEcho.pm Outdated Show resolved Hide resolved
@dracos dracos force-pushed the merton-ww-initial branch 12 times, most recently from 042f796 to 1e7efcd Compare April 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants