New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merton] Initial WasteWorks setup. #4902
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4902 +/- ##
==========================================
+ Coverage 82.58% 82.64% +0.05%
==========================================
Files 393 397 +4
Lines 30652 30799 +147
Branches 4846 4861 +15
==========================================
+ Hits 25315 25453 +138
- Misses 3894 3896 +2
- Partials 1443 1450 +7 ☔ View full report in Codecov by Sentry. |
cbe92c6
to
24328cc
Compare
a20a343
to
43b4165
Compare
24328cc
to
3f43fe0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple of comments, but nothing that should block merging or require re-review.
042f796
to
1e7efcd
Compare
Include a script to send waste reports to a second endpoint.
After the Echo refactoring, this is hopefully quite a bit smaller than it would have been previously.
This contains the core report/request functionality, basics thereof, with quite a bit shared with SLWP, so factored that out to a separate shared file.
https://github.com/mysociety/societyworks/issues/4224
https://github.com/mysociety/societyworks/issues/4225
https://github.com/mysociety/societyworks/issues/4226
[skip changelog]