Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kingston] Changes to container request emails #4898

Merged
merged 2 commits into from May 8, 2024

Conversation

davea
Copy link
Member

@davea davea commented Mar 27, 2024

  • New logo for all Kingston emails
  • Added some text to container request emails
  • Added link to request status page to container request emails

For FD-3630 (aka https://github.com/mysociety/societyworks/issues/4221)
Feedback given in https://mysocietysupport.freshdesk.com/a/tickets/4056

image

[skip changelog]

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.59%. Comparing base (4c4efdd) to head (132a02e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4898      +/-   ##
==========================================
- Coverage   82.59%   82.59%   -0.01%     
==========================================
  Files         392      392              
  Lines       30647    30647              
  Branches     4845     4845              
==========================================
- Hits        25314    25312       -2     
- Misses       3891     3893       +2     
  Partials     1442     1442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dracos dracos force-pushed the issues/freshdesk/3630-kingston-emails branch from 34e5d8d to d87c44c Compare April 16, 2024 13:16
@mysociety-pusher mysociety-pusher force-pushed the issues/freshdesk/3630-kingston-emails branch from d87c44c to d176f66 Compare May 1, 2024 15:28
@MorayMySoc MorayMySoc requested a review from dracos May 1, 2024 15:49
@MorayMySoc MorayMySoc self-assigned this May 1, 2024
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to add the track link to the alert-update.txt template as well.

templates/email/default/alert-update.html Outdated Show resolved Hide resolved
templates/email/default/waste/other-reported.html Outdated Show resolved Hide resolved
@MorayMySoc MorayMySoc requested a review from dracos May 2, 2024 09:04
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny tweaks is all :)

templates/email/default/waste/other-reported.txt Outdated Show resolved Hide resolved
templates/email/default/alert-update.txt Outdated Show resolved Hide resolved
@MorayMySoc MorayMySoc requested a review from dracos May 2, 2024 11:37
@MorayMySoc MorayMySoc requested a review from dracos May 7, 2024 09:05
@mysociety-pusher mysociety-pusher force-pushed the issues/freshdesk/3630-kingston-emails branch from 531e6ad to a05637b Compare May 7, 2024 09:21
@dracos dracos force-pushed the issues/freshdesk/3630-kingston-emails branch from e9de906 to e5feca5 Compare May 7, 2024 21:48
@dracos dracos marked this pull request as ready for review May 7, 2024 21:48
@dracos dracos force-pushed the issues/freshdesk/3630-kingston-emails branch from e5feca5 to 132a02e Compare May 8, 2024 08:20
@dracos dracos merged commit 132a02e into master May 8, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants