[Kingston] Container work #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4892 +/- ##
==========================================
+ Coverage 82.56% 82.59% +0.03%
==========================================
Files 392 392
Lines 30517 30647 +130
Branches 4819 4845 +26
==========================================
+ Hits 25196 25313 +117
- Misses 3882 3892 +10
- Partials 1439 1442 +3 ☔ View full report in Codecov by Sentry. |
dracos
force-pushed
the
sutton-capita-payment
branch
2 times, most recently
from
7a793e6
to
6cc4a9c
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
from
d53bea1
to
f96a234
Compare
dracos
changed the base branch from
sutton-capita-payment
to
sutton-container-change-size
davea
approved these changes
Mar 28, 2024
dracos
force-pushed
the
kingston-replacement-payment
branch
from
f96a234
to
9c54ea5
Compare
dracos
changed the base branch from
sutton-container-change-size
to
sutton-capita-payment
dracos
force-pushed
the
sutton-capita-payment
branch
from
1935d88
to
6bec23b
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
from
9c54ea5
to
6fa876a
Compare
dracos
force-pushed
the
sutton-capita-payment
branch
from
a8d9e92
to
dae29aa
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
from
6fa876a
to
47bdef4
Compare
dracos
force-pushed
the
sutton-capita-payment
branch
from
dae29aa
to
640ea6a
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
from
47bdef4
to
c217117
Compare
dracos
force-pushed
the
sutton-capita-payment
branch
from
640ea6a
to
07e1e68
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
2 times, most recently
from
5c33293
to
835690c
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
from
835690c
to
2aaea7c
Compare
|
Hi @davea, Parts of this you've already looked at, but has been rejigged due to changes in requirements (see updated issue). I've tried to make this most straightforward to implement by first stripping out all the extra bits that would no longer be needed (so just removals there), then add payments and how-many-live there (you've already reviewed those), then multiple bins (which you had reviewed, but now is for replacements as well as new as the damaged/missing is gone), then lastly the new change capacity (which is similar to the Sutton but done differently due to the extra questions/flow). Shout if you have any questions. |
davea
reviewed
Apr 30, 2024
dracos
force-pushed
the
kingston-replacement-payment
branch
from
2aaea7c
to
7fbcb7d
Compare
dracos
force-pushed
the
kingston-replacement-payment
branch
2 times, most recently
from
fa1530e
to
9e410b6
Compare
This could happen if someone picks a quantity but then changes their mind and unticks the box. Nothing uses the quantity without checking the container first.
Leaving only a sole-container replacement form, that always treats bin as Deliver/Missing.
dracos
force-pushed
the
kingston-replacement-payment
branch
from
64b6812
to
95d15ca
Compare
The bin being requested depends upon the answer.
This adds a removals page where people can say how many bins they want removing also; it then uses this information to work out what needs sending to the backend.
dracos
force-pushed
the
kingston-replacement-payment
branch
from
95d15ca
to
4c4efdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/mysociety/societyworks/issues/4199 (newly updated)
[skip changelog]