Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBeds] Stop road layer triggering for PROW #4858

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

MorayMySoc
Copy link
Contributor

Rights of way has to be excluded from the not on a road stopper or reports can't be made.

Map and server side in .com and society-servers with same branch name

https://mysocietysupport.freshdesk.com/a/tickets/3760

[skip changelog]

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (bf17009) to head (8f87d86).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4858      +/-   ##
==========================================
+ Coverage   82.60%   82.65%   +0.04%     
==========================================
  Files         387      387              
  Lines       30283    30369      +86     
  Branches     4771     4807      +36     
==========================================
+ Hits        25015    25100      +85     
+ Misses       3826     3824       -2     
- Partials     1442     1445       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment presumably needs changing to match?

In the server change, there aren't any "R Byway" entries I can see, if those are the right values to use.

@MorayMySoc MorayMySoc removed the request for review from neprune March 4, 2024 09:40
Rights of way has to be excluded from the not on a road
stopper or reports can't be made.

Map and server side in .com and society-servers with same branch name

https://mysocietysupport.freshdesk.com/a/tickets/3760
@dracos dracos force-pushed the 3760-cbeds-add-PROW-layer branch from 8f87d86 to 3727f42 Compare May 13, 2024 14:48
@dracos dracos merged commit 3727f42 into master May 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants