Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 - admin/groups module #4700

Open
wants to merge 4 commits into
base: feature
Choose a base branch
from
Open

PHP 8 - admin/groups module #4700

wants to merge 4 commits into from

Conversation

RevertIT
Copy link
Contributor

You can thank me later.

There were over 30+ undefined errors alone if god forbid we had errors while editing the group.

RevertIT and others added 4 commits May 15, 2023 18:33
@RevertIT
You can thank me later.
b7825fb 
There were over 30+ undefined errors alone if god forbid we had error while editing group.
@RevertIT
Merge branch 'mybb:feature' into patch-groups
62a2514
@RevertIT
Spacing fix
223ed52
@RevertIT
Add empty check for $errors array
2f407d1
@Sama34
Copy link
Contributor

Sama34 commented Oct 17, 2023

I might be missing something but it seems some of these changes to the get_input() are unnecessary. Unnecessary in the sense that there shouldn't be warnings by reviewing the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RevertIT @Sama34