Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CF-Turnstile support #4683

Open
wants to merge 9 commits into
base: feature
Choose a base branch
from

Conversation

RevertIT-alt
Copy link
Contributor

Resolves #4659

Tested locally and working fine so far, can be improved if needed.

Copy link
Contributor

@Sama34 Sama34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick look at the code it seems fine, but ideally live testing should be done.

@@ -164,6 +170,17 @@ function __construct($build = false, $template = "")
$this->build_hcaptcha();
}
}
elseif($this->type == captcha::CFTURNSTILE && $mybb->settings['cfturnstilepublickey'] && $mybb->settings['cfturnstileprivatekey'])
{
// We want to use hCaptcha or hCaptcha invisible, set the server options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The inline comment is wrong :P

member.php Outdated Show resolved Hide resolved
RevertIT and others added 2 commits May 27, 2023 12:12
Co-authored-by: Omar G <Sama34@users.noreply.github.com>
@yuliu
Copy link
Member

yuliu commented May 27, 2023

Contribution is welcome but please avoid using meaningless or ambiguous words / phrases for commit messages. You may check the article linked at https://github.com/mybb/mybb/blob/feature/.github/CONTRIBUTING.md#commits for recommendations for commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cloudflare Turnstile for captcha
4 participants