New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CF-Turnstile support #4683
base: feature
Are you sure you want to change the base?
Add CF-Turnstile support #4683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick look at the code it seems fine, but ideally live testing should be done.
inc/class_captcha.php
Outdated
@@ -164,6 +170,17 @@ function __construct($build = false, $template = "") | |||
$this->build_hcaptcha(); | |||
} | |||
} | |||
elseif($this->type == captcha::CFTURNSTILE && $mybb->settings['cfturnstilepublickey'] && $mybb->settings['cfturnstileprivatekey']) | |||
{ | |||
// We want to use hCaptcha or hCaptcha invisible, set the server options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inline comment is wrong :P
Co-authored-by: Omar G <Sama34@users.noreply.github.com>
Contribution is welcome but please avoid using meaningless or ambiguous words / phrases for commit messages. You may check the article linked at https://github.com/mybb/mybb/blob/feature/.github/CONTRIBUTING.md#commits for recommendations for commit messages. |
Resolves #4659
Tested locally and working fine so far, can be improved if needed.