PHP 8 - Fix various datahandler event.php and calendar.php errors
#4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`trim()` allow the blank description to be added with newlines and whitespaces. Replaced with `trim_blank_chrs()` to fix it.
`trim()` allow the blank description to be added with whitespaces. Replaced with `trim_blank_chrs()` to fix it.
This will fix datahandler `event.php` when updating the calendar event. Line `580` and line 586` are throwing errors and line `591` is redundant because errors are already thrown before we come to set a default value. Reference: https://github.com/mybb/mybb/blob/44be739f817fcc4b04afcbb91fc6d91b59815bba/inc/datahandlers/event.php#L580-L591
This will prevent users from adding an invalid year and invalidate timezone. The following example will throw an undefined error for the `timezone` array key... ```html <select name="single_year"> <option value="invalid_text">2023</option> </select> ```
dvz
reviewed
May 4, 2023
| } | ||
| else | ||
| { | ||
| $this->event_update_data['endtime'] = 0; | ||
| $this->event_update_data['usingtime'] = 0; |
There was a problem hiding this comment.
Is it supposed to not be set anymore?
There was a problem hiding this comment.
Yeah, L580 and L586 are throwing errors, and L591 is redundant because errors are already thrown before we come to set a default value.
There was a problem hiding this comment.
Looks like it may no longer be set/corrected when neither starttime nor endtime are set. It may be better to leave it to preserve the intended logic.
There was a problem hiding this comment.
Submitted a correction, this now should cover all the instances of endtime/usingtime
|
@dvz is this finished? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There could be more issues, but those are current ones that I manage to find and fix.