Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement date validation function #4246

Draft
wants to merge 9 commits into
base: feature
Choose a base branch
from

Conversation

effone
Copy link
Member

@effone effone commented Feb 2, 2021

Rework of earlier attempt #3212
This will address first task of #4015

Resolve #1071

Tasks:

  • Implement date validation function (cleanup)
  • Convert forwarding to error page to inline error (eg. return date in past)
  • UserCP Away Date : Validate away date
  • UserCP Away Date : Move all validations to datahandler
  • UserCP Away Date : Enable missing away date error trigger (code in place, never occurs)
  • UserCP Birthday : Validate through function
  • ModCP Birthday
  • ModCP Away Date
  • ACP Birthday
  • ACP Away Date
  • Calendar Start End
  • Delay Moderation date validation check

... this will increase as I dig in.

@effone
Copy link
Member Author

effone commented Feb 2, 2021

@effone what do you mean by syntax correction? You mean spell-checking?

No, it was being failed for auto check PHP Syntax Check / lint (ubuntu-latest, 5.3)
Apparently it came out as a mistake. Thanks @euantorano for implementing the checks making life easier.

@euantorano
Copy link
Member

@effone what do you mean by syntax correction? You mean spell-checking?

No, it was being failed for auto check PHP Syntax Check / lint (ubuntu-latest, 5.3)
Apparently it came out as a mistake. Thanks @euantorano for implementing the checks making life easier.

It definitely makes my life easier when reviewing :D

@Eldenroot
Copy link
Contributor

I havent found any other places... would be nice to have this in 1827 :)

@effone
Copy link
Member Author

effone commented Mar 12, 2021

No there are many places left in MCP & ACP
I need to cover time validation as well along with date. Need to manage some times to modify the function covering time validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No 'invalid date' error in other places
3 participants