New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #3654 Moderation Tools Improvements #3790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good so far, just one minor nitpick and a comment for myself.
@effone - please can you look at this and finish this one? |
This is done for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, mostly code style. I haven't tested this yet, just read the changes.
All comments addressed. |
Please can you review this? |
I applied to my board, at the first look and testing no problems so far. |
Current PHP code doesn't prevent users having relevant permissions from making a reply to a soft-deleted thread |
Anyone who wants to test this PR in an upgrades board for an existing one, please apply #3800. Had some tests with issues mentioned in #3654 and it looks to me that all the issues have been addressed. However, I have some further questions:
|
This is long pending @mybb/developers |
Thanks for the nudge @effone. I'll review it this week and merge. |
@euantorano - any feedback from testing? |
5 years later :) still a good improvement |
Resolves #3654 Moderation Tools Improvements # Conflicts: # inc/languages/english/showthread.lang.php # showthread.php
Attempt to resolve #3654