Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #3654 Moderation Tools Improvements #3790

Merged
merged 19 commits into from Apr 17, 2024

Conversation

effone
Copy link
Member

@effone effone commented Sep 7, 2019

Attempt to resolve #3654

Copy link
Member

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, just one minor nitpick and a comment for myself.

jscripts/thread.js Outdated Show resolved Hide resolved
@Eldenroot
Copy link
Contributor

@effone - please can you look at this and finish this one?

@effone effone marked this pull request as ready for review April 23, 2020 17:05
@effone
Copy link
Member Author

effone commented Apr 23, 2020

This is done for now.
I think I have completed all the to-dos of this PR. If I have left something I will address separately.

@effone effone modified the milestone: 1.8.23 Apr 23, 2020
Copy link
Member

@euantorano euantorano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, mostly code style. I haven't tested this yet, just read the changes.

moderation.php Outdated Show resolved Hide resolved
showthread.php Outdated Show resolved Hide resolved
showthread.php Outdated Show resolved Hide resolved
showthread.php Outdated Show resolved Hide resolved
showthread.php Outdated Show resolved Hide resolved
@effone
Copy link
Member Author

effone commented Apr 23, 2020

All comments addressed.

@Ben-MyBB
Copy link
Member

@effone - please can you look at this and finish this one?

Please can you review this?

moderation.php Outdated Show resolved Hide resolved
showthread.php Outdated Show resolved Hide resolved
@Eldenroot
Copy link
Contributor

I applied to my board, at the first look and testing no problems so far.

@yuliu
Copy link
Member

yuliu commented May 28, 2020

Current PHP code doesn't prevent users having relevant permissions from making a reply to a soft-deleted thread

@yuliu
Copy link
Member

yuliu commented Jun 5, 2020

Anyone who wants to test this PR in an upgrades board for an existing one, please apply #3800.

Had some tests with issues mentioned in #3654 and it looks to me that all the issues have been addressed. However, I have some further questions:

  • Thread Split is enabled even if there is only one post. I think this improvement could be applied to inline post mod tools as well for Merge posts, Split posts and Move posts. It doesn't matter if it's not changed.

@effone
Copy link
Member Author

effone commented Jan 11, 2021

This is long pending @mybb/developers

@euantorano
Copy link
Member

Thanks for the nudge @effone. I'll review it this week and merge.

@Eldenroot
Copy link
Contributor

@euantorano - any feedback from testing?

@euantorano euantorano self-assigned this Mar 22, 2021
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
install/resources/mybb_theme.xml Outdated Show resolved Hide resolved
@Eldenroot
Copy link
Contributor

Eldenroot commented Apr 16, 2024

5 years later :) still a good improvement

@effone effone requested a review from Sama34 April 16, 2024 19:25
@Ben-MyBB Ben-MyBB merged commit 526feb9 into mybb:feature Apr 17, 2024
8 checks passed
dvz pushed a commit that referenced this pull request May 1, 2024
Resolves #3654 Moderation Tools Improvements
# Conflicts:
#	inc/languages/english/showthread.lang.php
#	showthread.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderation Tools Improvements
7 participants