Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User CP input validation - move to datahandler #4015

Open
1 of 3 tasks
euantorano opened this issue May 28, 2020 · 6 comments · May be fixed by #4313
Open
1 of 3 tasks

User CP input validation - move to datahandler #4015

euantorano opened this issue May 28, 2020 · 6 comments · May be fixed by #4313
Labels
b:1.8 Branch: 1.8.x easy-pick Not difficult; good first issue to resolve t:code-quality Type: Code Quality. Improves code without affecting functionality

Comments

@euantorano
Copy link
Member

euantorano commented May 28, 2020 •
edited by effone

The user CP do_profile action has some validation done in usercp.php that then uses error(). This validation should be moved to the user data handler:
@euantorano euantorano added b:1.8 Branch: 1.8.x easy-pick Not difficult; good first issue to resolve t:code-quality Type: Code Quality. Improves code without affecting functionality labels May 28, 2020
@euantorano euantorano added this to the 1.8.24 milestone May 28, 2020
@Ben-MyBB Ben-MyBB self-assigned this May 28, 2020
@Ben-MyBB
Copy link
Member

I'll take a look at creating a PR for this to go into 1.8.24.

@yuliu
Copy link
Member

yuliu commented Jun 17, 2020 •
edited

Hmm, just found out that these input fields also exist in ModCP but don't have validations. So #4014 isn't enough, and moving the validations to user handler should benefit both UserCP and ModCP, and probably AdminCP..

@effone
Copy link
Member

effone commented Feb 2, 2021 •
edited

Just a note to put here, I am willing to implement a date validation function affecting all date inputs in MyBB.
Currently MyBB accepts impossible dates like 31-2-2020 (d-m-Y)

@effone effone mentioned this issue Feb 2, 2021
Draft
12 tasks
@Eldenroot
Copy link
Contributor

@Ben-MyBB - are you willing to continue with this?

@Ben-MyBB Ben-MyBB removed their assignment Feb 24, 2021
@Ben-MyBB
Copy link
Member

@Eldenroot I probably don't have the time to continue this one for now so I've unassigned myself, feel free to complete if you wish.

@Eldenroot Eldenroot linked a pull request Mar 13, 2021 that will close this issue
Open
@dvz dvz removed this from the 1.8.27 milestone May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x easy-pick Not difficult; good first issue to resolve t:code-quality Type: Code Quality. Improves code without affecting functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #4015 - User CP input validation Eldenroot/mybb
7 participants
@euantorano @Eldenroot @yuliu @dvz @Ben-MyBB @effone and others